Restore compare flow and add startDate ≤ endDate validation#57
Merged
lukepring merged 4 commits intoSprint-2-Jackfrom Mar 20, 2026
Merged
Restore compare flow and add startDate ≤ endDate validation#57lukepring merged 4 commits intoSprint-2-Jackfrom
lukepring merged 4 commits intoSprint-2-Jackfrom
Conversation
Merged
Co-authored-by: lukepring <68820847+lukepring@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback from review on Sprint 2 jack PR
Add startDate ≤ endDate validation to /compare endpoint
Mar 20, 2026
Owner
|
@copilot Ensure merge conflict was fixed correctly and this pull request works pls |
Co-authored-by: lukepring <68820847+lukepring@users.noreply.github.com>
Contributor
Author
Fixed the merge regression in |
Copilot
AI
changed the title
Add startDate ≤ endDate validation to /compare endpoint
Restore compare flow and add startDate ≤ endDate validation
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
/comparewould accept an invalid date range and proceed to the API, yielding empty data and a misleading error. After a merge regression it also stopped using the base branch compare flow. This update restores the intended comparison call and adds a clear date-range check.Changes
priceController.comparePrices(base branch behavior) and handles empty results as before.start≤end, surfacing a clear error message and avoiding unnecessary API calls.Testing
./mvnw test🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.